Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enableTracing option in v8 #3776

Merged
merged 15 commits into from
Oct 10, 2024
Merged

Remove enableTracing option in v8 #3776

merged 15 commits into from
Oct 10, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Oct 8, 2024

📜 Description

enableTracing is confusing to many people, so we are removing it again.

💡 Motivation and Context

Closes #3566

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b002e8d

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 446.35 ms 489.67 ms 43.33 ms
Size 1.70 MiB 2.35 MiB 665.14 KiB

Previous results on branch: feat/remove-enable-tracing

Startup times

Revision Plain With Sentry Diff
60d895f 427.43 ms 481.81 ms 54.38 ms

App size

Revision Plain With Sentry Diff
60d895f 1.70 MiB 2.35 MiB 665.14 KiB

@adinauer adinauer changed the title Remove enableTracing option Remove enableTracing option in v8 Oct 8, 2024
Base automatically changed from feat/remove-metrics to 8.x.x October 9, 2024 11:24
@adinauer adinauer merged commit 93ee8ee into 8.x.x Oct 10, 2024
21 of 22 checks passed
@adinauer adinauer deleted the feat/remove-enable-tracing branch October 10, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants